Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve composer.json #310

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Improve composer.json #310

merged 1 commit into from
Jul 11, 2024

Conversation

williamdes
Copy link
Contributor

I removed the "archive" part that I had added, it does not work.

Using @php ensures that the composer commands can be run with different php versions, else it would not work.

php8.x /bin/composer run phpunit

@coveralls
Copy link

Coverage Status

coverage: 99.872%. remained the same
when pulling 3db1552 on williamdes:patch-1
into 753e964 on slimphp:master.

@williamdes williamdes mentioned this pull request Jul 10, 2024
Merged
@akrabat akrabat merged commit 3123744 into slimphp:master Jul 11, 2024
5 of 6 checks passed
@akrabat akrabat added this to the 1.8.0 milestone Jul 11, 2024
@akrabat
Copy link
Member

akrabat commented Jul 11, 2024

Thanks.

@williamdes williamdes deleted the patch-1 branch July 11, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akrabat akrabat akrabat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@williamdes @coveralls @akrabat